node-opcua / node-opcua / 28798221203

92%

Build Type

push

github

Committed by erossignon

Commit Message

fix(server): store non-secret identity key and fail closed on unsupported token

Address review of sessionsCompatibleForTransfer:

1. Never throw. When the source/destination identity token is missing on one side
   only, or is a type we don't explicitly handle (e.g. IssuedIdentityToken), the
   function previously fell through to `throw new Error("Unsupported Identity
   token")`, which could turn a client TransferSubscriptions request into an
   unhandled server error. It now fails closed (returns false) in those cases.

2. Don't retain secrets. The retained identity snapshot (ITransferSessionIdentity,
   kept on orphaned subscriptions after the owning session is gone) previously held
   the raw UserIdentityToken, which for UserNameIdentityToken / IssuedIdentityToken
   carries sensitive bytes (Password / TokenData). It now stores only a minimal,
   non-secret key: identity kind, userName, and the X509 certificate SHA1 thumbprint.

Adds SCT-18 (asymmetric missing token -> refused, no throw) and SCT-19 (unsupported
token -> refused, no throw); SCT-11 now asserts the password is not retained.

Coverage Stats

19809 of 23091 branches covered (85.79%)

81 of 81 new or added lines in 1 file covered. (100.0%)

528 existing lines in 6 files now uncovered.

168764 of 183139 relevant lines covered (92.15%)

442963.3 hits per line