node-opcua / node-opcua / 28734850276

92%

Build Type

push

github

Committed by erossignon

Commit Message

fix(client): prevent reconnection deadlock after sleep/wake

_throwIfShouldNotContinue was called inside async callbacks within
Promise constructors (create_session_and_repeat_if_failed line 190,
attempt_subscription_transfer line 302). When the session becomes
unusable during reconnection (e.g. transport closes again after
laptop sleep/wake), the throw:
  - escapes the Promise (only sync throws are caught)
  - is swallowed by the secure channel's modified_callback try/catch
  - leaves the Promise dangling (never resolved/rejected)
  - the reconnection state machine stays stuck in 'reconnecting'
  - subsequent _repairConnection calls are blocked by the
    re-entrancy guard

Replace _throwIfShouldNotContinue with _shouldNotContinue + reject()
at both sites so the Promise properly rejects, allowing the
reconnection state machine to recover and retry.

Add test_reconnection_deadlock.ts proving the bug: the buggy pattern
causes the Promise to deadlock, the fixed pattern rejects cleanly.

Coverage Stats

19762 of 23043 branches covered (85.76%)

4 of 4 new or added lines in 1 file covered. (100.0%)

3 existing lines in 1 file now uncovered.

168568 of 182964 relevant lines covered (92.13%)

471556.05 hits per line