enbility / ship-go / 28795888195

93%

Build Type

push

github

Committed by web-flow

Commit Message

hub: prevent concurrent duplicate outgoing connections to the same SKI (#85)

`connectFoundService` only dedupes outgoing dials via `isSkiConnected`,
which becomes true after `registerConnection` (i.e. after the websocket
dial + SHIP handshake). Two concurrent outgoing dials to the same SKI
can both pass that check, both establish, and then `keepThisConnection`
tears one down mid-discovery. Some remotes then stop answering
measurement reads on the surviving connection until the whole service is
restarted.

Reserve the SKI for the duration of the dial via a new
`connectionsInitiating` set (guarded by `muxCon`), so a concurrent
outgoing dial returns early instead of racing to a second handshake. The
incoming-vs-outgoing case is still handled by `keepThisConnection`.

This is a real-live issue observed as a stalled EEBus meter on a
Vaillant heatpump in evcc-io/evcc#30889. PR is done by Claude but lgtm.

Coverage Stats

20 of 20 new or added lines in 2 files covered. (100.0%)

4 existing lines in 2 files now uncovered.

5821 of 6261 relevant lines covered (92.97%)

11672.24 hits per line