MushroomObserver / mushroom-observer / 28791597694

99%

main: 99%

Build Type

Pull #4700

github

Committed by nimmolo

Commit Message

Fix real gaps the full suite caught: Comment/TranslationString callers

Full-suite run after the Comment and TranslationString conversions
surfaced two caller patterns the plan missed:

- Names::Synonyms::SharedPrivateMethods#post_comment builds/saves a
  Comment directly (not through CommentsController#create), with no
  current_user set - a real attribution gap now that check_user/
  no_recent_duplicate no longer fall back to the global.
- test/models/observation_test.rb's email-notification tests build
  Comment.create(...) directly with User.current set beforehand,
  relying on the same fallback.
- test/models/language_test.rb's set_text helper calls str.save
  directly (TranslationString's only production writer is
  LanguageExporter, but tests exercised the model directly), relying
  on User.current to drive update_version?'s per-user version
  collapsing.

Thread current_user/user explicitly through all of them.

Pull Request Pull Request #4700: Convert Comment/Herbarium/GlossaryTerm/NameTracker/TranslationString/UserStats/LanguageExporter off User.current

Coverage Stats

31 of 31 new or added lines in 11 files covered. (100.0%)

3 existing lines in 1 file now uncovered.

51667 of 52303 relevant lines covered (98.78%)

747.26 hits per line