pmd / pmd / 644

79%

push

github

[java] Fix #6826: AssertEqualsArgumentOrder false positive for double/float delta (#6827)

The wildcard assertEquals(_,_,_) matchers for org.junit.Assert and
junit.framework.TestCase modeled the 3-arg form as (message?, expected,
actual), so for the delta overload assertEquals(double expected, double
actual, double delta) they read the delta as "actual" and flagged
correctly-ordered calls.

Replace the wildcards with the forms actually in use: (String,_,_) and
(String,_,_,_) for the message variants, (double,double,double) and
(float,float,float) for the deltas. The message + delta form was not
matched at all before, so a swap there went undetected.

Fixes pmd/pmd#6826.

Co-authored-by: Sören Glimm <git@uncleowen.de>

19178 of 25155 branches covered (76.24%)

Branch coverage included in aggregate %.

41598 of 51596 relevant lines covered (80.62%)

0.81 hits per line