Freegle / Iznik / 25125

72%

Build Type

push

circleci

Committed by invalid-email-address

Commit Message

fix(ripple): scope proximity-note routing to the reach budget (stop slow-call Sentry storm)

ripple:proximity-notes called group-proximity with no max_minutes, so the routing
server explored its default 120-minute isochrone for every note — even though the
posts had only rippled ~22-30 min out. That made each call ~4x heavier (~3s on
dense-urban networks) and tripped the "ripple: slow group-proximity 3016ms"
warning en masse: 4282x overnight on one high-ripple group (21521,
manchestergreencycleuk), wasting ~3.5h of routing CPU and flooding Sentry. The
calls are best-effort and out of the hot ripple path, so nothing broke — but it's
pure waste.

Pass the reach's own max_drive_min (already joined from rippling_reach) as
max_minutes. A post only rippled into groups within its reach, so the note never
needs to explore further; bounded calls drop below the 3s slow threshold.

Not fixed here (separate, touches rippling_proximity semantics): the cron writes
no marker when a post yields no note (unreachable / not-quicker), so those posts
are re-tried every run for 8 days. Worth a "checked, no note" sentinel later.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01VqZianMqz6i4FKMdPgnvWM

Coverage Stats

12392 of 16407 branches covered (75.53%)

Branch coverage included in aggregate %.

13 of 13 new or added lines in 2 files covered. (100.0%)

2 existing lines in 2 files now uncovered.

131632 of 184061 relevant lines covered (71.52%)

38.07 hits per line