jhheider / edikt / 28767419069

96%

push

github

fix(kdl): carry nested child comments through conversion; bump to 0.2.1 (#44)

* test: raise edikt-kdl coverage

Extend the edikt-kdl test module with meaningful unit tests over the
previously-uncovered error paths and edge cases in edit.rs, comments.rs,
and project.rs: del() arity/non-path/non-mutation errors, assignment paths
that don't start with a node name, missing-intermediate creates, indexing
and field-stepping repeated nodes, the `-` ARGS_KEY arg replace/set/delete,
"property is a scalar" / "holds arguments not children" / bare-node-grows-
children paths, `[]` in assignment paths, comment-target resolution errors,
foot-comment unsupported, inline-comment delete + CRLF line endings,
value_to_nodes with multi-arg `-`, build_document/emit on a non-object,
repeated-node extend prefix-match failures, and every scalar kind (wide
int -> float, float, bool, null) both projected and emitted.

Line coverage: edit.rs 70.0% -> 98.2%, comments.rs 78.4% -> 98.4%,
project.rs 86.4% -> 98.8%.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01YC4AaBNYxo2zz3QTqgF3Ua

* fix(kdl): carry nested child-node comments through conversion; bump to 0.2.1

Extraction (`node_commented`) flattened a node's children comment-free -- it
only lifted the node's own head/inline -- so a comment on a nested KDL node was
lost on `-T`/conversion even though emission already recurses. `node_commented`
now recurses via a new `node_body_commented` that mirrors `project::node_to_value`
(args/props are comment-free scalars) and pulls children from `doc_commented`,
so nested head/inline comments survive extraction and round-trip.

- edikt-kdl 0.2.0 -> 0.2.1 (behaviour fix), edikt 0.2.0 -> 0.2.1 (ships it via
  its edikt-kdl dependency); workspace pin bumped to match. The other crates
  stay at 0.2.0 -- first exercise of the per-crate versioning.
- Adds `nested_child_comments_survive_extraction` (regression) and the 43 kdl
  coverage t... (continued)

290 of 297 new or added lines in 2 files covered. (97.64%)

9544 of 9928 relevant lines covered (96.13%)

84.52 hits per line