paskal / spot / 28754878221

84%

master: 84%

Build Type

push

github

Committed by paskal

Commit Message

executor: fix context-cancellation leaks, local copy bugs, drop dead options

- sshRun: buffer the done channel so the command goroutine can exit
  after a ctx-cancel return instead of blocking forever (goroutine leak).
- sftpUpload/sftpDownload: build the sftp client over an ssh session we
  hold (newSftpSession), and on ctx-cancel close that session, then drain
  the copy goroutine before returning. Closing the ssh session tears the
  channel down from outside the sftp mutex, so a stalled transfer is
  actually aborted (closing the sftp client would block on the same mutex
  a wedged write holds); the drain removes the deferred-Close vs io.Copy
  race. A new test cancels a 32MB transfer mid-flight and asserts it
  returns rather than hanging.
- Local.Upload: with a multi-file glob and mkdir, create the destination
  directory itself (it is treated as a directory) instead of only its
  parent, and honor context cancellation between files.
- Local.Download: pass the caller context through instead of
  context.Background().
- Connector.String: cap the private-key slice with min() so it does not
  panic on short or empty (agent-only) keys.
- Remove dead options never read by any executor: Checksum from
  UpDownOpts and SyncOpts, and Force from SyncOpts. This also drops the
  config sync 'force' field (an undocumented no-op) and its schema entry.
  Behavior change: under strict YAML parsing a playbook that set
  'sync: {force: true}' will now fail to parse.

Coverage Stats

39 of 59 new or added lines in 4 files covered. (66.1%)

86 existing lines in 3 files now uncovered.

3222 of 3846 relevant lines covered (83.78%)

58.54 hits per line