paskal / spot / 28750023671

84%

master: 84%

push

github

executor: fix context-cancellation leaks, local copy bugs, drop dead options

- sshRun: buffer the done channel so the command goroutine can exit
  after a ctx-cancel return instead of blocking forever (goroutine leak).
- sftpUpload/sftpDownload: on ctx-cancel, close the per-call sftp client
  to abort the in-flight transfer, then wait for the copy goroutine to
  finish before returning so the deferred Close no longer races the
  io.Copy. Closing the client (not the file) avoids blocking behind the
  sftp write mutex, so cancellation stays prompt.
- Local.Upload: with a multi-file glob and mkdir, create the destination
  directory itself (it is treated as a directory) instead of only its
  parent, and honor context cancellation between files.
- Local.Download: pass the caller context through instead of
  context.Background().
- Connector.String: guard the private-key slice so it does not panic on
  short or empty (agent-only) keys.
- Remove dead options never read by any executor: Checksum from
  UpDownOpts and SyncOpts, and Force from SyncOpts. This also drops the
  config sync 'force' field (an undocumented no-op) and its schema entry;
  under strict YAML parsing a playbook that set 'sync: {force: true}'
  would now fail to parse, which is intended cleanup.

25 of 30 new or added lines in 4 files covered. (83.33%)

3209 of 3818 relevant lines covered (84.05%)

58.76 hits per line