tecnickcom / gogen / 28751990389

100%

push

github

feat(httpretrier)!: rebuild on shared backoff, fix retry correctness, and honor Retry-After

Extract the duplicated exponential-backoff-with-jitter math into a new pkg/backoff (a pure per-call Schedule plus a standalone AddJitter; additive/full/equal jitter strategies; overflow-safe, non-negative bounds) and rebuild the retry and scheduling packages on it, replacing three diverging copies of the delay logic and the obsolete pre-Go-1.23 timer-drain dance.

- backoff: new package providing the shared delay Schedule and the AddJitter helper, both fully bounded and jitter-strategy aware.
- httpretrier: make Do a synchronous select loop (drop the per-call goroutine, background context, and channel handoff) so a panic in a user callback reaches the caller instead of crashing the process; uphold the response-XOR-error contract on every return path (cancellation, body-close error, and non-conforming clients); open the replay body lazily so an aborted retry never leaks it; add optional Retry-After support via WithRespectRetryAfter/WithMaxRetryAfter (jittered so clients do not re-synchronize); add WithJitterStrategy and a WithOnRetry observability hook; guard the exported retry policies against a nil response; and fail fast on an already-canceled request context.
- retrier: adopt pkg/backoff; add WithMaxDelay, WithJitterStrategy, and WithOnRetry; correct the "attempts" docs to mean total attempts (initial call plus retries).
- periodic: pace via backoff.AddJitter; make Start/Stop idempotent and race-free (a Stop ordered before Start prevents the loop from ever launching); drop the unnecessary reset channel.

All four packages retain 100% test coverage and pass go test -race with a clean golangci-lint run.

299 of 299 new or added lines in 6 files covered. (100.0%)

12871 of 12875 relevant lines covered (99.97%)

98155.82 hits per line