tecnickcom / gogen / 28746980286

100%

push

github

feat(httpreverseproxy)!: enforce base-path boundary, redact error logs, and fix forwarding defaults

Harden the reverse-proxy client: validate configuration up front, close a path-traversal gap, stop leaking query secrets into logs, and fix forwarding and transport defaults that broke custom setups and streaming.

Security:
- When the upstream address carries a base path, reject (HTTP 400) any request whose path resolves outside it via "." / ".." before the upstream is contacted; strict by default, opt out with WithLaxBasePath. The configured base path is normalized (path.Clean) so a non-normalized base does not reject every request.
- Never follow upstream redirects: 3xx responses are forwarded verbatim instead of being fetched by the proxy, avoiding an SSRF vector.

Redaction and observability:
- Redact the request query string and the URL embedded in a failed request's *url.Error before logging (configurable via WithRedactFn, default redact.HTTPDataString), and drop the always-empty request_uri field.
- Treat a client that disconnected before the upstream responded (inbound context canceled or deadline exceeded) as a client-closed request, logged at Info with the non-standard 499 code and no 502 written; genuine upstream failures stay a 502 at Error. The distinction is drawn from the inbound context state so an upstream ResponseHeaderTimeout still reports as 502.

Correctness:
- Validate the upstream address in New: require an http/https scheme and a host, returning ErrInvalidAddress instead of building a silently broken proxy from inputs like "" or "localhost:8080".
- Install the default rewrite only when the supplied proxy has neither a Rewrite nor a Director set, so a custom WithReverseProxy Director is no longer overridden by an injected Rewrite that made ReverseProxy reject every request.
- Drop the redundant SetURL call and clear RawPath in the default rewrite so the outbound escaped path is re-derived from the freshly built path.

Transport,... (continued)

178 of 178 new or added lines in 2 files covered. (100.0%)

12699 of 12706 relevant lines covered (99.94%)

138823.25 hits per line