dangernoodle-io / breadboard / 28715880884

100%

push

github

refactor: bb_cache config-struct API + topic->key + key-copy w/ CONFIG_BB_CACHE_KEY_MAX (B1-576) (#711)

- collapse bb_cache_register/_ex into bb_cache_register(const bb_cache_config_t *cfg);
  migrate every call site (bb_net_health, bb_info, bb_ota_check, bb_display_info,
  bb_diag_routes, bb_sub, bb_pub) with explicit .flags = BB_CACHE_FLAG_SSE where the
  old positional bb_cache_register defaulted to SSE, avoiding a silent SSE break
- rename the registry-identity concept topic->key throughout bb_cache (config field,
  bb_cache_entry_t, find_entry/find_entry_locked, foreach/key_at); keep "topic" where
  it genuinely names the wire/pub-sub identifier (event_topic, SSE ?topic=, MQTT)
- bb_cache now copies the key into a fixed CONFIG_BB_CACHE_KEY_MAX buffer (default 96,
  sized to cover bb_sub's dynamic ingress keys) instead of storing the caller's
  pointer verbatim, closing the pointer-lifetime footgun; over-length keys are
  rejected with BB_ERR_INVALID_ARG rather than silently truncated
- add host tests for config-struct registration, key-copy (no UAF after the caller
  frees its key buffer), over-length key rejection, and SSE-flag default preservation

Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>

2262 of 2262 branches covered (100.0%)

Branch coverage included in aggregate %.

5 of 5 new or added lines in 2 files covered. (100.0%)

3796 of 3796 relevant lines covered (100.0%)

1210.07 hits per line