OpenCyphal-Garage / cy / 28714204327

100%

main: 100%

push

github

Fix silent drop of best-effort publish on custom-named pinned CAN topics (H5)

Pinned best-effort publishes were always sent on the headerless Cyphal/CAN
v1.0 13-bit plane, so the receiver could only match topics literally named
"<sid>" (the N#N idiom); any other name (e.g. foo/bar#611) hash-missed and was
silently dropped while cy_publish still returned CY_OK.

Take the 13-bit plane only when the message's topic hash equals
rapidhash(decimal(sid)) -- exactly the condition under which the receiver's
fabricated phony header matches. Every other name uses the v1.1 16-bit plane
with the real header. The TX detector (topic_is_compat_named) and the RX
fabricator (build_phony_header) share one compat_topic_hash() helper so they
cannot drift.

Add regression tests: custom-named pinned best-effort delivery (foo/bar#611)
and multi-tenant pinned delivery+filtering (foo#1234 + bar#1234); both fail
pre-fix and pass after.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

530 of 530 branches covered (100.0%)

Branch coverage included in aggregate %.

2268 of 2282 relevant lines covered (99.39%)

406946.14 hits per line