OpenCyphal-Garage / cy / 28707957886

100%

main: 100%

push

github

Remove vestigial automatic-cleanup logic (L4/L5)

The publisher lifecycle carried a half-built remnant of an abandoned
"auto-cancel on teardown" design. The library now relies solely on the
existing manual-cleanup contract: the application destroys its own
futures/publishers/subscribers before tearing down the owning scope.

- Delete the dead cy_publisher_t::publish_futures list and its init; it
  was never populated or read. Live publish futures are tracked in the
  per-topic pub_futures_by_tag tree, which is unaffected.
- Delete the incomplete #ifndef NDEBUG scan in cy_unadvertise. It could
  never see request futures (they key on the topic, not a publisher, so
  a topic may host several publishers) and could not be made complete.
  A terse rationale comment replaces it; the topic-level teardown asserts
  remain the complete backstop.
- Remove the dead write-only cy_t::topic_count counter (the traces that
  print "topic_count=" are fed by cavl_count(), not this field).
- Add two regression guards in test_intrusive_future_notify_destroy.c:
  contract-compliant teardown of a pending publish future, and reaping of
  a finalized request-future zombie via cy_destroy. Both mutation-verified.
- Mark L4 and L5 resolved (moved into todo/resolved/).

Full test suite green with static analysis (clang-tidy + cppcheck),
101/101 across the x64/x32 x C99/C11 matrix.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01PcYxhcpUyzYqSDdHZEGQW4

530 of 530 branches covered (100.0%)

Branch coverage included in aggregate %.

2268 of 2282 relevant lines covered (99.39%)

406942.3 hits per line