source-academy / frontend / 28709856838

41%

push

github

fix(playground): reset side content tab to Introduction on language switch (#4063)

* fix(playground): reset side content tab to Introduction on language switch

Switching the Conductor-selected language (e.g. Python §1 to §2) left
whatever side content tab was active untouched. A tab tied to the
previous language — like the plugin-provided Stepper tab — has no
guarantee of still applying to the new one, so it was left pointing at
a now-dead evaluator instance and hung forever.

Reset unconditionally on any language switch rather than special-casing
the Stepper, since any tab can be language-specific, not just that one.
The legacy Source/full-JS/Java/C chapter+variant picker already resets
the tab via `resetSideContent` in the `chapterSelect` saga; this covers
the Conductor language-directory picker, which had no equivalent.

Fixes #4061.

* fix(playground): avoid stale closure in evaluator-id selectors

stepperEvaluatorId/defaultEvaluatorId closed over the outer
selectedLanguageId instead of reading it from the selector's own state
argument. react-redux can invoke a selector from a store update before
the component re-renders, so the outer variable could momentarily lag
behind the state the selector itself sees. Read it from state directly,
matching the pattern already used elsewhere in this file.

Addresses Gemini Code Assist feedback on PR #4063.

---------

Co-authored-by: Shrey Jain <“shreyjain5132@email.com>

2659 of 7500 branches covered (35.45%)

Branch coverage included in aggregate %.

7 of 12 new or added lines in 1 file covered. (58.33%)

6289 of 14129 relevant lines covered (44.51%)

27.08 hits per line