dangernoodle-io / breadboard / 28694181739

100%

push

github

feat: bbdevice device/ota — generic OTA verbs with injectable health_fn + carried TA-532 ScopeViolation guard (#705)

- move fleet's fleetlib/ota.py to device/ota.py: generic /api/update/* verbs (push/pull/mark_valid/recover/status/verify/reboot/wait_for_boot), behavior-faithful to fleet
- post-OTA health check is now an injectable health_fn(client, info) -> (ok, detail); the generic default is reachable-only (returns (True, {})). the mining hashrate/reset-reason assessment stays in fleet, to be injected as health_fn at cutover
- version-match is checked independently of health_fn, so a passing health_fn cannot mask a version mismatch
- carry the #614 TA-532 ScopeViolation guard: _check_scope raises (from .safety) before any HTTP when a device is outside the explicit --hosts scope
- pull() gains criteria/profile/health_fn params (uniform with push; additive, no regression)
- verify() resolves for_profile before wait_until_ready, fixing a latent no-op in fleet's verify (behavior-neutral for current callers, which pass profile=None)
- readiness adaptation: bbdevice's wait_until_ready has no profile param, so profile->criteria overrides are resolved locally in verify/reboot/_post_boot_verify
- landing dependency: fleet must inject its hashrate/reset-reason health_fn when it cuts over to bbdevice.device.ota (fleet-consume PR), or OTA validation degrades to reachable-only

Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>

2260 of 2260 branches covered (100.0%)

Branch coverage included in aggregate %.

3784 of 3784 relevant lines covered (100.0%)

1203.67 hits per line