umputun / spot / 28688857844

84%

push

github

Fix only_on exclusion lists and bare address matching

Previously, an only_on list containing only negated entries (e.g.
only_on: [!host1]) skipped the command on every host: a non-excluded
host matched no positive entry and fell through to the final return
false, contradicting the documented "run on all hosts except"
behaviour. Also, bare addresses like only_on: [1.2.3.4] never matched in
remote mode because the runner compares against the host:port form.

After this change, exclusion-only lists allow all hosts which are not
explicitly excluded, and addresses are compared against the host name,
the full host:port address, and the bare host part, so a bare address
matches a host:port host but a different port does not. An exclusion now
wins over an inclusion regardless of their order in the list (the whole
list is scanned before deciding), so a merged list like
[host1, !host1] excludes the host. The shouldRunCmd godoc describes the
semantics, and new Test_shouldRunCmd cases cover the exclusion-only
fallthrough, mixed-list host-matching-neither, host:port precision, and
exclusion-wins-over-inclusion in both orders.

15 of 15 new or added lines in 1 file covered. (100.0%)

3125 of 3718 relevant lines covered (84.05%)

58.55 hits per line