umputun / spot / 28688779358

84%

master: 84%

Build Type

Pull #352

github

Committed by paskal

Commit Message

Fix multiline wait swallowing errors, wire delete exclude through

Previously, a multiline wait command that timed out was reported as
successful when the remote temp-dir cleanup succeeded, because the
teardown defer overwrote the returned error with nil.

Previously, the delete command ignored its documented exclude patterns
and removed files the playbook asked to keep. Wiring it through:

- isExcludedSubPath now protects any ancestor of an excluded path, not
  just the immediate parent, so exclusions nested deeper than one level
  survive.
- Remote recursive delete removes the whole tree when no exclude pattern
  matched, matching the local executor, and logs a WARN in that case so
  a mistyped pattern is not silently destructive.
- The dir-glob rule (a 'dir/*' pattern also protecting the directory it
  names) is now gated on the entry being a directory, threaded through
  all isExcluded call sites, so a pattern like 'dir*/*' no longer
  excludes a plain file such as 'data.txt'.
- Exclusion matching uses forward-slash semantics on all platforms, so
  documented patterns work with windows local paths too.
- exclude requires recur and is rejected without it, symmetric between
  sudo and non-sudo; sudo+exclude is still rejected. Both errors name the
  offending location, and mdelete validates all entries before deleting
  any of them.

The wait teardown fix mirrors Script: the teardown error is only
surfaced when there is no primary error.

Pull Request Pull Request #352: Fix multiline wait swallowing errors, wire delete exclude through

Coverage Stats

87 of 93 new or added lines in 4 files covered. (93.55%)

112 existing lines in 2 files now uncovered.

3167 of 3762 relevant lines covered (84.18%)

59.1 hits per line