umputun / spot / 28681600797

84%

master: 84%

Build Type

Pull #352

github

Committed by paskal

Commit Message

Fix multiline wait swallowing errors, wire delete exclude through

Previously, a multiline wait command that timed out was reported as
successful when the remote temp-dir cleanup succeeded, because the
teardown defer overwrote the returned error with nil.

Previously, the delete command ignored its documented exclude patterns
and removed files the playbook asked to keep. Recursive delete also
removed exclusions nested deeper than one level, because
isExcludedSubPath only protected the immediate parent directory; it now
protects any ancestor of an excluded path. Remote recursive delete
removes the whole tree, including parent directories of potential
exclusions, when no exclusion pattern actually matched. Glob directory
patterns like dir*/* now protect the matching directories themselves,
and exclusion matching uses forward-slash semantics on all platforms,
so documented patterns work with windows local paths too. Delete with
both sudo and exclude is rejected upfront (for mdelete before any
location is deleted), as sudo deletion runs plain rm which cannot apply
exclusions.

Pull Request Pull Request #352: Fix multiline wait swallowing errors, wire delete exclude through

Coverage Stats

52 of 56 new or added lines in 3 files covered. (92.86%)

138 existing lines in 3 files now uncovered.

3145 of 3740 relevant lines covered (84.09%)

58.66 hits per line