Freegle / Iznik / 24549

72%

Build Type

push

circleci

Committed by edwh

Commit Message

fix(browse): make the nearby feed honour browseMaxDistance so it matches the unread badge

A Tower Hamlets moderator saw the browse unread badge say 3 while 9 posts sat above the
"You're up to date" divider. Two causes, both fixed:

1) The feed ignored the distance preference. isochrone.Count -> nearbyCount filters unseen
   posts to the member's browseMaxDistance, but isochrone.Messages returned every reach-
   covered post regardless. The client slider hid the far ones visually, but their `unseen`
   flag still put them above the divider, so badge != feed. Messages now applies the SAME
   resolveMaxDistance filter as the count (reads ?maxDistance= else the saved setting), so
   the unseen posts the feed shows and the badge count come from one universe. Own posts
   (blurred distance ~0 from the viewer) always pass; only far reach posts drop; no pinned
   exemption, so it matches nearbyCount exactly. New TestNearbyFeedHonoursDistanceLimit
   mirrors TestNearbyCountDistanceLimit for the feed.

2) Stale feed cache after "Mark seen". markSeen() marked the server + polled the count to
   zero but never cleared the cached feed's `unseen` flags, so posts lingered above the
   divider (and a second device's cache stayed stale). Now markSeen also clears the local
   flags immediately (nearbyStore.markSeen) and, once the count clears, refetches the feed
   (nearbyStore.fetchMessages(true)) so the divider split comes from server truth.

Full Go suite: the only failures are the unrelated Bulk* tests hitting a stale local test
DB missing the new bulk-offer `edittoken` migration (CI runs a migrated DB); every browse/
isochrone/count test passes.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AsgvoSgfeUwBMBbxKJHSNy

Coverage Stats

12266 of 16221 branches covered (75.62%)

Branch coverage included in aggregate %.

19 of 19 new or added lines in 2 files covered. (100.0%)

52 existing lines in 3 files now uncovered.

130673 of 183121 relevant lines covered (71.36%)

37.83 hits per line