kibertoad / toad-cache / 28661564489

100%

push

github

Improve input validation and fix statistics tracking edge cases (#102)

* fix: correctness issues found in audit

- Reject non-integer and non-number max/ttl in all cache constructors:
  values like 2.5, '5', Infinity or true previously passed validation
  but never matched the strict size === max eviction check, so the
  cache grew without bound; a string ttl string-concatenated into the
  expiry timestamp, silently disabling expiration
- Evict on size >= max instead of strict equality as defense in depth
- LruObjectHitStatistics: use ?? for defaults so explicit max = 0
  (unbounded everywhere else) is no longer coerced to 1000
- LruObjectHitStatistics: don't count invalidateOne for deletes of
  missing keys or evictions on an empty cache
- HitStatisticsRecord.resetForCache: no-op for unknown cacheId instead
  of throwing
- Type declarations: add missing getStatistics() to HitStatisticsRecord
  and LruObjectHitStatistics, export CacheStatistics, fix LruMap/FifoMap
  items type to Map<any, CacheEntry<T>>
- README: fix LruHitStatistics example (options object throws; the real
  constructor is positional), document integer max and the runtime-ttl
  expiry caveat
- Add regression tests for all of the above

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01EbhrjjB2UdFJQ5fdnGKZzv

* test: verify max:0 is truly unlimited (no eviction)

* refactor: address review findings from PR #102

- Extract shared validateCacheParams() helper, removing the validation
  block duplicated across FifoMap/FifoObject/LruMap/LruObject
- Make ttl validation consistent with max: reject non-integers and
  Infinity (was only checking NaN), closing the gap where ttl=Infinity
  silently produced never-expiring entries
- Extract createEmptyStatisticsRecord() factory, removing the zeroed
  record literal duplicated across initForCache/resetForCache and
  HitStatistics.currentRecord (which had drifted in field ordering)
- LruObject... (continued)

186 of 186 branches covered (100.0%)

Branch coverage included in aggregate %.

17 of 17 new or added lines in 6 files covered. (100.0%)

343 of 343 relevant lines covered (100.0%)

118.6 hits per line