zwave-js / zwave-js-ui / 28651819450

8%

Build Type

push

github

Committed by web-flow

Commit Message

feat: allow managing statistics opt-in via external settings (#4716)

I noticed quite the uptick in Z-Wave JS UI installations, but none at
all in HA - turns out this was a bug. The way we run Z-UI in HA caused
Z-Wave JS UI to report to the statistics backend (after opt-in there),
without HA ever having the chance to announce that it was involved. To
fix this, we'll make the statistics opt-in as externally managed.

When `enableStatistics` is set in the external settings file, the
statistics opt-in dialog is no longer shown, the setting is hidden in
the UI and the /api/statistics endpoint rejects changes. This lets a
managing application (e.g. the Home Assistant add-on) own the statistics
opt-in through the Z-Wave JS Server API, so usage is attributed to the
correct application name and version.

Co-authored-by: Claude Fable 5 <noreply@anthropic.com>

Coverage Stats

325 of 4236 branches covered (7.67%)

Branch coverage included in aggregate %.

0 of 6 new or added lines in 2 files covered. (0.0%)

1 existing line in 1 file now uncovered.

538 of 6560 relevant lines covered (8.2%)

1.54 hits per line