dangernoodle-io / breadboard / 28647300496

100%

push

github

refactor(reboot): migrate remaining esp_restart sites to bb_system_restart_reason, retire ota_boot_stg breadcrumb (B1-527) (#690)

- add BB_RESET_SRC_OTA_BOOT_ABORT to the closed bb_reset_source_t enum (appended before __COUNT to keep NVS numbering stable) and its host test
- migrate bb_wifi (safeguard reboot, cold-connect timeout, reconfigure-apply, pending-cred revert), bb_ota_pull (pull-applied), bb_ota_push (push-applied), and bb_ota_boot (arm/apply, pull-done, and every abort path collapsed onto OTA_BOOT_ABORT with a detail tag) off raw esp_restart() onto bb_system_restart_reason()
- add bb_system to PRIV_REQUIRES for bb_wifi, bb_ota_pull, bb_ota_push, bb_ota_boot
- remove bb_ota_boot's write-only ota_boot_stg breadcrumb (breadcrumb() helper + OTA_BOOT_STAGE_KEY), superseded by the new reboot-reason tagging
- defer the bb_nv factory-reset site (esp_restart() stays bare) — bb_system already PRIV_REQUIRES bb_nv, so tagging it would form a component cycle; documented as a follow-up
- document the funnel + deferred exception + breadcrumb retirement in CLAUDE.md

Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>

2226 of 2226 branches covered (100.0%)

Branch coverage included in aggregate %.

3747 of 3747 relevant lines covered (100.0%)

1205.92 hits per line