Freegle / Iznik / 24477

72%

Build Type

push

circleci

Committed by edwh

Commit Message

fix(browse): hide a poster's own posts pruned from messages_spatial (expired/withdrawn)

The browse "own posts" arm (GET /isochrone/message and /message/inbounds) shows the
viewer their own recent posts regardless of reach by querying the messages table
directly. It applied the same age-based expiry My Posts uses, but not My Posts' other
active-set condition: My Posts requires spatialid IS NOT NULL (the post is still in
messages_spatial) OR the post is Pending/Rejected. So an Approved own post that had been
pruned from messages_spatial - expired, withdrawn, deleted or taken - but still had no
messages_outcomes row and an arrival within the 90-day own-posts window kept showing on
browse for the poster, even though My Posts had already hidden it.

Reported: a ~2.5-month-old "Misanthropic calendar" OFFER (gone from messages_spatial, no
outcome row) was still showing first in the poster's own Closest feed.

Fix: add the same "EXISTS in messages_spatial OR collection IN (Pending, Rejected)"
condition to the own-posts query, so a poster's own post drops off browse at the same
moment it drops off My Posts. Pending/Rejected posts are never in spatial, so those keep
showing - that's the point of this arm: the poster sees their post immediately, including
while it awaits moderation.

Test: TestBrowseOwnPrunedFromSpatialHidden - an own post removed from messages_spatial is
hidden; one still in spatial is shown; a Pending one (never in spatial) is shown. Full Go
suite green (3369 passing).

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AsgvoSgfeUwBMBbxKJHSNy

Coverage Stats

12186 of 16110 branches covered (75.64%)

Branch coverage included in aggregate %.

13 of 13 new or added lines in 1 file covered. (100.0%)

2 existing lines in 1 file now uncovered.

129999 of 182428 relevant lines covered (71.26%)

37.99 hits per line