IJHack / QtPass / 28634577885
63%

DEFAULT BRANCH: main
Ran
Jobs 1
Files 81
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 56.397% (+0.01%) from 56.387%
28634577885

push

github

web-flow 
fix: prevent use-after-free of the keygen dialog pointer (#1603)

* fix: prevent use-after-free of the keygen dialog pointer

The keygen dialog is created on the caller's stack (ConfigDialog::
on_pushButtonGenerateKey_clicked runs KeygenDialog d; d.exec()) and
KeygenDialog::done() starts gpg --gen-key asynchronously without closing the
dialog, so the modal loop keeps running and the dialog stays interactive. If
the user closes it (window close button or Escape) while generation is still in
flight, exec() returns and the stack dialog is destroyed — but MainWindow's raw
m_keyGenDialog still points at it. When gpg finishes, onKeyGenerationComplete()
calls cleanKeygenDialog(), which does m_keyGenDialog->close() on freed memory.

Make m_keyGenDialog a QPointer<QDialog> so it auto-clears when the dialog is
destroyed; getKeyGenDialog()/cleanKeygenDialog() then correctly observe nullptr
and skip the dangling close. Includes a regression test that destroys the
dialog after generateKeyPair() and asserts the pointer reads back as null.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01JuQsrHonihp1nARE7bzstc

* test: parent keygen-dialog test widget to avoid Qt 5.15 teardown crash

The regression test created a top-level QDialog and deleted it without hiding
it; on the Qt 5.15 offscreen platform this leaves a dangling active-window
pointer that segfaults during QApplication teardown (all assertions pass, then
the process crashes on exit). Parent the dialog to the MainWindow so it is
never a top-level widget. No change to what the test verifies.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01JuQsrHonihp1nARE7bzstc

* test: drop keygen-dialog UAF test pending Qt 5.15 teardown investigation

The test passed on all platforms but its simulate-destruction sequence
segfaulted the tst_mainwindow binary during Qt 5.15 offscreen QAppl... (continued)

3791 of 6722 relevant lines covered (56.4%)

30.43 hits per line

Jobs
ID Job ID Ran Files Coverage
1 28634577885.1 81
56.4
 GitHub Action Run
Source Files on build 28634577885