decentraland / world-storage-service / 28623054580

99%

main: 99%

Pull #111

github

refactor: address P2 review comments

- Drain the body of the final non-OK upstream response before throwing/returning
  on the Places, worlds-content-server, and LAMBDAS error paths. The fetcher
  cancels bodies of retried responses itself but hands the final response to the
  caller, so an unconsumed undici body would pin its socket and buffer bytes
  until GC under sustained upstream failures. Adds a shared discardResponseBody
  helper next to UPSTREAM_FETCH_OPTIONS.
- Document why validateEnvStorageUpsert omits the NUL-character check (env values
  are stored in a bytea column, not jsonb) and note that adding content
  validation there must also be caught in upsertEnvStorageHandler.
- Revert the edit to the already-deployed covering-index migration
  (1782604800000) back to its released form; the follow-up migration replaces
  those indexes anyway, so editing an applied migration only risks drift.

351 of 362 branches covered (96.96%)

Branch coverage included in aggregate %.

175 of 179 new or added lines in 30 files covered. (97.77%)

1078 of 1084 relevant lines covered (99.45%)

71.19 hits per line