coreui / coreui-pro / 28605786025

95%

Build Type

push

github

Committed by web-flow

Commit Message

fix(time-picker): label hour column by picker mode, not locale default (#580)

* fix(time-picker): label hour column by picker mode, not locale default

formatTimePartials formatted hour labels with the locale's default cycle, so a
24-hour picker in a 12-hour-default locale (en-US, en-CA) rendered duplicated
12-hour labels (12,01,…,11,12,01,…) instead of 00…23, and older ICU labelled
midnight "24". Thread the picker's hour mode through and pin an explicit
hourCycle (h23 for 24-hour, h12 for 12-hour) so labels follow the mode on every
engine.

* chore: bump bundlewatch limits for the time-picker hour-cycle fix

The explicit hourCycle logic adds a few bytes to the non-minified bundles,
nudging coreui.bundle.js and coreui.esm.js just over their gzip budgets.

Coverage Stats

2778 of 3068 branches covered (90.55%)

Branch coverage included in aggregate %.

2 of 2 new or added lines in 1 file covered. (100.0%)

1 existing line in 1 file now uncovered.

7159 of 7436 relevant lines covered (96.27%)

747.48 hits per line