lsm / neokai / 28604318833

82%

Build Type

push

github

Committed by web-flow

Commit Message

fix(web): reset useAutoScroll latch on context switch via resetKey (#2223)

* fix(web): reset useAutoScroll latch on context switch via resetKey

useAutoScroll only reset its initial bottom-scroll latch on mount, when
isInitialLoad flipped back to true, or when messageCount hit 0. A parent
that swaps the underlying data in place without unmounting (and without
messageCount passing through 0) left hasScrolledOnMountRef latched true
from the previous context, so the hook preserved a stale scroll position
instead of snapping to the latest messages.

Add an optional resetKey (sessionId / taskId). When it changes, reset the
mount-scroll latch and message-count tracker so the next non-empty render
is treated as a fresh visit. Wire resetKey: sessionId in ChatContainer and
resetKey: taskId in SpaceTaskUnifiedThread (which renders without a key, so
it stays mounted across task switches). Add a regression test covering a
direct messageCount swap (40 -> 25) without dropping to 0.

* fix(web): re-run auto-scroll when resetKey changes (same messageCount)

Add resetKey to the auto-scroll layout effect's dependency array. Without
it, switching between two contexts that happen to have the same messageCount
(e.g. two tasks with 25 rows each) left resetKey as the only changed input:
the reset effect cleared the latch, but the auto-scroll effect never re-ran,
so the old scroll position was preserved. Add a test covering the
same-messageCount resetKey change.

* fix(web): refresh height snapshot on resetKey context reset

On a same-message-count context switch, resetKey is the only changed input,
so the scroll-detection effect does not re-run and lastScrollHeightRef keeps
describing the previous (e.g. taller) thread. If the new thread's content
grows asynchronously after the initial scroll, the ResizeObserver compares
against that stale height, grew stays false, and it never re-pins to the
bottom. Reset lastScrollHeightRef alongside the other context refs in the
resetKey... (continued)

Coverage Stats

11529 of 16607 branches covered (69.42%)

Branch coverage included in aggregate %.

8 of 8 new or added lines in 1 file covered. (100.0%)

1 existing line in 1 file now uncovered.

98209 of 116513 relevant lines covered (84.29%)

301.71 hits per line