NodeBB / NodeBB / 28601225474

85%

push

github

fix: clear stuck loading indicator on bfcache restore (#14419)

When a full-page navigation is triggered from within an in-flight ajaxify transition (e.g. onAjaxError redirecting to /login or an external URL, or handleRedirects opening the admin panel), action:ajaxify.end never fires, so the loading indicator keeps running and #content keeps its 'ajaxifying' class. The browser stores the page in the back/forward cache in that state, and pressing Back restores it with the indicator stuck, so the page appears to hang.

Add a pageshow handler that, on a persisted (bfcache) restore where the ajaxifying state is still set, refreshes the current page. This clears the loading indicator through the normal render cycle and reconnects the socket via ajaxify.go. It is gated on the stuck state, so ordinary bfcache restores are unaffected.

14068 of 19216 branches covered (73.21%)

29415 of 34442 relevant lines covered (85.4%)

3479.45 hits per line