kobotoolbox / kpi / 28597602232

81%

master: 76%

push

github

feat(bulkProcessing): review button better navigation DEV-2322 (#7204)

### 📣 Summary

Clicking the Review button on a translation now opens directly to that
specific language instead of defaulting to the most recent one.

### 💭 Notes

Changes here:
- **routerConstants.ts**: Added new `TRANSLATION_DETAIL` route pattern
with `:languageCode` parameter (`/translations/:languageCode`)
- **routes.tsx**: Added the translation detail route (placed before
generic translations route for proper matching - route order matters!)
- **routes.utils.ts**: 
- Extended `ProcessingRouteParts` interface to include optional
`languageCode`
- Updated `getProcessingRouteParts()` to match translation detail routes
first, then fall back to generic routes
- Added `getActiveLanguageCode()` helper to extract language from
current URL
- Modified `goToProcessing()` to accept optional `languageCode` and use
translation detail route when provided
- **SelectSubmission.tsx**: Pass `getActiveLanguageCode()` when
navigating between submissions (keeps you on the same translation)
- **SelectQuestion.tsx**: Pass `getActiveLanguageCode()` when switching
questions (same deal)
- **TabTranslations/index.tsx**: 
  - Read `languageCode` from URL params via `useParams()`
  - Pre-select translation based on URL on initial load
- Update URL when user manually switches languages (so the URL stays in
sync)
- **SupplementalDetailsCell.tsx**: Pass `languageCode` when Review
button navigates to translations
- **routes.utils.tests.ts**: Added test coverage for language code
routing (22 tests, all passing 🎉)

### 👀 Preview steps

Since bulk translation is not working currently, we need some
alternative ways of testing this PR

**Setup:**
1. ℹ️ Have a project with audio questions and some submissions
2. Go to Project → Data → Table
3. Click on a submission row to open Single Processing view
4. Navigate to the Translations tab

**Test 1: Manual translation creation updates URL**
5. Create a manual translatio... (continued)

9259 of 12599 branches covered (73.49%)

30214 of 37100 relevant lines covered (81.44%)

5.52 hits per line