lsm / neokai / 28591036690

82%

push

github

fix(web): keep space task composer from restoring deleted text (#2219)

* fix(web): keep space task composer from restoring deleted text

In the worker-agent thread composer, draft text was frequently not deletable:
select-all + delete would bring the text back, sometimes leaving a stray letter.

Root cause: useInputDraft clobbers its in-memory draft to '' and reloads the
server draft whenever its sessionId prop changes. In the task thread that id
comes from resolveTargetSessionId, which flips to null mid-composition when its
two source LiveQueries (nodeExecutions.byRun and spaceTaskActivity.byTask)
momentarily disagree — it returns null whenever the node-execution id is known
but no activity member matches yet, skipping the agentName fallback while
nodeExecutionId is set. The null flip made the draft wipe and reload the stale
server copy, restoring the deleted text.

Fix: latch the resolved session per target in useTargetSessionContext so a
transient resolution gap can't null it out mid-composition. The id stays stable
until the target genuinely changes, so useInputDraft never clobbers/reloads.

Regression tests: resolved session survives an empty activityMembers tick;
switching to a genuinely different unstarted target does not inherit the latch.

* fix(web): scope task-thread composer session latch by taskId

The session latch added to fix deleted-text restoration was keyed only by
target id. Workflow composer target ids are reused across tasks
(node:<nodeId>:<agentName>), and SpaceTaskPane stays mounted across task
switches (no key=taskId on its render site). So switching to a second task
whose activity hadn't loaded yet inherited the first task's coder session —
marking an unstarted agent as started and wiring draft/model state to the
wrong task's session.

Scope the latch key by (taskId, target). nodeExecutionId is deliberately
excluded: a transient null during an execution-id transition is exactly the
gap the latch exists to ride out, and inclu... (continued)

11524 of 16599 branches covered (69.43%)

Branch coverage included in aggregate %.

19 of 19 new or added lines in 2 files covered. (100.0%)

98014 of 116287 relevant lines covered (84.29%)

301.37 hits per line