tarantool / luajit / 28574258036

93%

push

github

FFI/MacOS: Fix calling convention for on-stack varargs.

Thanks to Sergey Kaplun.

(cherry picked from commit a2bde6081)

This commit fixes the regression introduced by the commit
82ca68442 ("FFI/MacOS: Fix calling
convention for enums."). The `isva` flag is set to 0 even for vararg
functions. Thus, arguments on the stack may be aligned incorrectly,
leading to the crash.

This patch fixes the behaviour by adjusting the flag value instead of
resetting it. In addition to the original test, various tests have been
added to cover the behaviour of the vararg FFI calls.

Sergey Kaplun:
* added the description and the test for the problem

Part of tarantool/tarantool#12480

Reviewed-by: Evgeniy Temirgaleev <e.temirgaleev@tarantool.org>
Reviewed-by: Sergey Bronnikov <sergeyb@tarantool.org>
Signed-off-by: Sergey Kaplun <skaplun@tarantool.org>

5730 of 6058 branches covered (94.59%)

Branch coverage included in aggregate %.

21855 of 23556 relevant lines covered (92.78%)

3972207.58 hits per line