tarantool / luajit / 28554408866

93%

push

github

Prevent sanitizer warnings for lj_tab_new*() and table.new().

Reported by Sergey Bronnikov.

(cherry picked from commit 8f421c81e)

The Undefined Behaviour Sanitizer [1] produces a warning because
the function `lua_createtable()` takes signed integer arguments,
but the `lj_tab_new_ah()` was not properly validating or converting
these signed values before using them in unsigned arithmetic.

The fix changes the signature of `lj_tab_new_ah()` to accept
uint32_t directly, and adjusts `lua_createtable()` to cast the
incoming signed int values to uint32_t before passing them.

[1]: https://clang.llvm.org/docs/UndefinedBehaviorSanitizer.html

Sergey Bronnikov:
* added the description and the test for the problem

Part of tarantool/tarantool#12480

Reviewed-by: Evgeniy Temirgaleev <e.temirgaleev@tarantool.org>
Reviewed-by: Sergey Kaplun <skaplun@tarantool.org>
Signed-off-by: Sergey Kaplun <skaplun@tarantool.org>

5735 of 6058 branches covered (94.67%)

Branch coverage included in aggregate %.

3 of 3 new or added lines in 2 files covered. (100.0%)

21885 of 23556 relevant lines covered (92.91%)

3972287.4 hits per line