ingitdb / dalgo2ingitdb / 28569548084

89%

Build Type

push

github

Committed by web-flow

Commit Message

feat: per-space nested on-disk scoping (Option A) + golden-fixture format contract (#2)

* docs: root-cause + design fork for per-space (parent-chain) scoping gap

Nested dal.Keys (spaces/family/contacts/c1 vs spaces/work/contacts/c1)
collide on disk. Root cause is the ingitdb data model (subcollection DirPath
derived from schema layout, never parameterized by parent record id;
def_validator.go:127-142) + the flat leaf-only resolver here
(tx_readonly.go:184-192). Documents two fix options (A: nest under parent
record dir, core ingitdb-go change, recommended; B: localized parent-chain
path encoding in this adapter with scope-aware queries) and defers the
on-disk-format choice to an owner decision. No code fix applied.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01FV3pbooAc9UPpNdiaJuKve

* feat: scope nested records by parent chain on disk (Option A)

Nested dal.Keys now nest physically under their parent record, mirroring
Firestore's document/subcollection layout so a repo stays human-browsable:
  spaces/family/contacts/c1.yaml   (key spaces/family/contacts/c1)
  spaces/work/contacts/c1.yaml     (key spaces/work/contacts/c1)
Previously both collapsed to a flat contacts dir and clobbered each other.

- New resolveScopedCollection() walks the key/CollectionRef parent chain and
  returns a copy of the target collection def with a DirPath scoped to the
  concrete parent-record path. Top-level (parent==nil) keys are unchanged.
- resolveCollection() (Get/Set/Delete/Exists/Update) and collectionFromQuery()
  (queries) both route through it, so reads/writes/queries agree on the path.
- Regression test TestNestedKeys_ScopedByParentRecord: two same-id contacts
  under different spaces round-trip independently (fails without the fix).
- Bump dalgo v0.46.1 -> v0.62.2 to match the code (GROUP BY/HAVING/AggregateFunc
  were already used but go.mod still pinned v0.46.1 -> main was red-building).

Owner decis... (continued)

Coverage Stats

41 of 55 new or added lines in 3 files covered. (74.55%)

138 existing lines in 1 file now uncovered.

2184 of 2412 relevant lines covered (90.55%)

1.08 hits per line