decentraland / social-service-ea / 28544267284

90%

push

github

fix: stop logging "Duplicate subscription detected" per occurrence; keep the metric (#426)

The per-occurrence debug log floods the logs (hundreds/min at DEBUG) when a client is stuck
re-subscribing to the same event — the current production symptom of the (not-yet-deployed)
client-side re-subscribe loop. The duplicate itself is expected and benign: the #407 guard is
doing its job (preventing a second generator/value-queue for the same connection+event).

Track it ONLY via the existing subscription_duplicates_total metric (labelled by event) and
drop the per-occurrence log line. A sustained high rate on that metric flags a looping client
without flooding the logs.

2296 of 2685 branches covered (85.51%)

Branch coverage included in aggregate %.

5757 of 6220 relevant lines covered (92.56%)

80.78 hits per line