dangernoodle-io / breadboard / 28543884353

100%

push

github

fix: align C #ifndef defaults with Kconfig defaults; centralize BB_PUB_TELEM_SNAP_MAX (B1-459) (#644)

- bump BB_PUB_TELEM_SNAP_MAX host fallback 256->512 in bb_pub.c to match Kconfig
- hoist the 7 hand-copied BB_PUB_TELEM_SNAP_MAX fallback blocks into one shared
  components/bb_pub/include/bb_pub_defaults.h, included by all 7 sites
- lower BB_EVENT_ROUTES_MAX_CLIENTS fallback 4->2 (common.c + test_route_fidelity
  mirror) to match Kconfig; no test relies on the old higher value
- lower BB_EVENT_ROUTES_QUEUE_DEPTH fallback 32->8 to match Kconfig; update the
  stale oversize-test comment (33 still exceeds 8)
- lower BB_EVENT_MAX_TOPICS fallback 16->8 to match Kconfig; native test env
  already overrides this via -DCONFIG_BB_EVENT_MAX_TOPICS=64, so no test
  behavior changes; clarify the stale comment
- lower BB_MDNS_TXT_PENDING_MAX fallback 8->4 to match Kconfig (ESP-IDF-only,
  dead in real builds since sdkconfig.h always defines CONFIG_)
- raise BB_TELEMETRY_MAX_SECTIONS fallback 4->6 to match Kconfig; keep the
  platformio.ini host override at 4 with a comment clarifying it's intentional
- fix BB_TIMER_DISP_CORE fallback 1->-1 to match Kconfig (ESP-IDF-only, dead
  in real builds)
- hoist the BB_EVENT_ROUTES_MAX_CLIENTS/QUEUE_DEPTH fallback pair into a shared
  components/bb_event_routes/include/bb_event_routes_defaults.h, included by
  bb_event_routes_common.c and test_route_fidelity.c
- align the host-only BB_MDNS_HOST_TXT_PENDING_MAX test shadow to 4 to match
  the now-corrected production BB_MDNS_TXT_PENDING_MAX; note the sync
  requirement in a comment
- delete the disabled, stale-magic dead test
  test_bb_event_topic_register_exceeds_max_returns_no_space (never run,
  asserted a stale 16); topic-exhaustion coverage remains via the active
  test_bb_event_topic_register_returns_no_space_when_full

Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>

1840 of 1840 branches covered (100.0%)

Branch coverage included in aggregate %.

3167 of 3167 relevant lines covered (100.0%)

1283.12 hits per line