grpc
/
grpc-java
/
#20345
89%
master: 89%
master: 89%
|
Ran
|
Jobs
1
|
Files
647
|
Run time
1min
|
Badge
Embed ▾
README BADGES
|
coverage: 88.778% (-0.02%) from 88.802%
push
github
ejona86Revert "xds: reuse GrpcXdsTransport and underlying gRPC channel to the same xDS server by ref-counting" This reverts commit e39c38bf5. This causes hangs for xds when MAX_CONCURRENT_STREAMS limit is too low for the number of targets being used. Each XdsClient will often use 2 streams (ADS, LRS), so a concurrency limit of 100 will likely have issues after 50 targets. Hitting MAX_CONCURRENT_STREAMS prevents the resource timer from being started as the ADS RPC does not become ready, so users see a hang instead of an xds resource timeout after 15 seconds. b/529399722
35996 of 40546 relevant lines covered (88.78%)
0.89 hits per line
Coverage Regressions
| Lines | Coverage | ∆ | File |
|---|---|---|---|
| 5 |
83.02 |
-9.43% | ../core/src/main/java/io/grpc/internal/Http2Ping.java |
| 3 |
95.07 |
-0.44% | ../core/src/main/java/io/grpc/internal/RetriableStream.java |
| 2 |
87.35 |
-0.79% | ../core/src/main/java/io/grpc/internal/DelayedClientCall.java |
| 2 |
81.05 |
-2.11% | ../okhttp/src/main/java/io/grpc/okhttp/ExceptionHandlingFrameWriter.java |
| 2 |
96.49 |
-0.73% | ../xds/src/main/java/io/grpc/xds/GrpcXdsTransportFactory.java |
| 1 |
47.62 |
-4.76% | ../core/src/main/java/io/grpc/internal/PickSubchannelArgsImpl.java |
| 1 |
74.23 |
-1.03% | ../servlet/src/main/java/io/grpc/servlet/AsyncServletOutputStreamWriter.java |
| 1 |
91.9 |
-0.48% | ../xds/src/main/java/io/grpc/xds/client/ControlPlaneClient.java |
Jobs
| ID | Job ID | Ran | Files | Coverage | |
|---|---|---|---|---|---|
| 1 | #20345.1 | 647 |
88.78 |
