grpc
/
grpc-java
/
#20344
89%
master: 89%
master: 89%
|
Ran
|
Jobs
1
|
Files
653
|
Run time
2min
|
Badge
Embed ▾
README BADGES
|
coverage: 88.858% (+0.03%) from 88.833%
push
github
ejona86Revert "xds: reuse GrpcXdsTransport and underlying gRPC channel to the same xDS server by ref-counting" This reverts commit e39c38bf5. This causes hangs for xds when MAX_CONCURRENT_STREAMS limit is too low for the number of targets being used. Each XdsClient will often use 2 streams (ADS, LRS), so a concurrency limit of 100 will likely have issues after 50 targets. Hitting MAX_CONCURRENT_STREAMS prevents the resource timer from being started as the ADS RPC does not become ready, so users see a hang instead of an xds resource timeout after 15 seconds. b/529399722
36272 of 40820 relevant lines covered (88.86%)
0.89 hits per line
Coverage Regressions
| Lines | Coverage | ∆ | File |
|---|---|---|---|
| 3 |
90.21 |
-1.05% | ../core/src/main/java/io/grpc/internal/DelayedClientCall.java |
| 2 |
96.49 |
-0.73% | ../xds/src/main/java/io/grpc/xds/GrpcXdsTransportFactory.java |
| 1 |
74.23 |
-1.03% | ../servlet/src/main/java/io/grpc/servlet/AsyncServletOutputStreamWriter.java |
| 1 |
91.59 |
-0.47% | ../xds/src/main/java/io/grpc/xds/client/ControlPlaneClient.java |
Jobs
| ID | Job ID | Ran | Files | Coverage | |
|---|---|---|---|---|---|
| 1 | #20344.1 | 653 |
88.86 |
