IJHack / QtPass / 28526360412

63%

Build Type

push

github

Committed by web-flow

Commit Message

fix: report gpg keygen start failures instead of hanging (#1598) (#1599)

* fix: report gpg keygen start failures instead of hanging (#1598)

When gpg failed to start (missing/unstartable binary, e.g. a Flatpak
sandbox denial — #637), the keygen command carried its batch on stdin, so
Executor::executeNext() took the waitForStarted() branch and, on failure,
dequeued the command without emitting finished() or error(). Pass::finished
was never invoked, cleanKeygenDialog() never ran, and the modal keygen
dialog spun forever with no success or failure feedback. An empty configured
gpg path hit the same dead-end via Executor::execute()'s empty-app return.

- Executor: emit error(id, -1, ...) on FailedToStart so the failure routes
  through Pass::finished's existing non-zero exit-code gate to the
  "GPG key pair generation failed" path. Deferred via a queued call so it
  does not re-enter KeygenDialog::done(), which drives keygen synchronously.
- Pass::GenerateGPGKeys: surface processErrorExit() when the gpg executable
  is unconfigured instead of handing an empty command to the Executor.
- Add regression tests: a failed-to-start stdin command now emits exactly
  one error() with a non-zero code (previously zero signals), and a
  signal-killed process reports CrashExit with a non-zero code.

The original unconditional-success defect was already fixed in 8df346373;
this closes the remaining silent-failure path.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01NCin4yQwkNeYzTvGQhThqG

* test: cover GenerateGPGKeys unconfigured-gpg path (#1598)

Add an integration regression test asserting that Pass::GenerateGPGKeys emits
processErrorExit with a non-zero code (and not finishedGenerateGPGKeys) when no
gpg executable is configured, covering the empty-path guard added in this PR.
No real gpg is invoked, so it runs without a keyring.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic... (continued)

Coverage Stats

11 of 16 new or added lines in 2 files covered. (68.75%)

8 existing lines in 1 file now uncovered.

3714 of 6704 relevant lines covered (55.4%)

29.29 hits per line