decentraland / social-service-ea / 28523199876

90%

main: 90%

Build Type

Pull #425

github

Committed by LautaroPetaccio

Commit Message

fix: give outbound HTTP a timeout + make catalyst/registry failures observable

Undici (native fetch) applies no request timeout unless one is configured, so a stalled
upstream (catalyst / registry / archipelago) could pin a keep-alive socket and block the caller
for minutes. Transient failures were also largely invisible (the retrier was silent; the
registry threw without logging).

- components: build the fetch component with a timeout (HTTP_FETCH_TIMEOUT_MS, default 10s) and
  idempotent retries (HTTP_FETCH_ATTEMPTS, default 3) — fail fast instead of multi-minute hangs.
- retrier: add an optional onRetry hook so callers can log transient failures (previously silent).
- catalyst-client: take `logs`; log each retried attempt (warn) and the final failure (error).
- registry: route getProfiles/getProfile through one fetchProfilesFromRegistry helper that logs
  the failure (network or non-ok) at the source before rethrowing.

Build, lint and full unit suite (106 suites / 1615 tests) green.

Pull Request Pull Request #425: fix: give outbound HTTP a timeout + make catalyst/registry failures observable

Coverage Stats

2291 of 2686 branches covered (85.29%)

Branch coverage included in aggregate %.

14 of 18 new or added lines in 4 files covered. (77.78%)

41 existing lines in 1 file now uncovered.

5761 of 6225 relevant lines covered (92.55%)

79.42 hits per line