Freegle / Iznik / 24201

72%

push

circleci

fix(rippling): align stale ripple:backfill/ExpandService tests with the command's behaviour

Three tests in the ripple:backfill commit asserted a pre-refactor command shape and failed
on master:
- test_second_run_seeds_nothing expected "Seeded 0 reach row(s)", but on zero candidates the
  command intentionally short-circuits with "Nothing to backfill." (and never prints the seed
  summary). Assert that instead.
- test_same_shard_is_single_instanced_via_its_own_lock held the old lock name
  "ripple:backfill:run:shard2-0"; the --recompute upgrade made the lock mode-scoped, so the
  command now takes "ripple:backfill:seed:shard2-0". Hold the current name.
- test_reposted_pre_go_live_post_gets_reach_after_spatial_refresh registered a catch-all
  Http::fake() before fakeRouting(); the first-registered stub wins, so the catch-all shadowed
  the ripple-schedule stub and the reach computation got no schedule (nothing seeded). Drop the
  catch-all - unmatched requests already fall through to Laravel's default no-op 200.

Tests only; no production change.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

11320 of 13033 branches covered (86.86%)

Branch coverage included in aggregate %.

128170 of 181115 relevant lines covered (70.77%)

36.59 hits per line