akvo / akvo-mis / #687

88%

push

coveralls-python

Feature/241 remove windowforms (#242)

* [#241] Add design doc: remove window.forms, runtime forms fetch

Design for replacing the window.forms global (baked into config.min.js)
with a runtime GET /api/v1/forms/published fetch into the pullstate store,
so newly published forms reflect without a config rebuild or hard reload.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* [#241] Add GET /forms/published endpoint; stop baking forms in config

- new list_published_forms view (AllowAny, Cache-Control: no-cache) returns
  all published forms (parents + children) with full content
- get_published_forms_payload() helper in functions.py, cached via shared
  get_cache/create_cache; PUBLISHED_FORMS_CACHE key in constants.py
- generate_config no longer emits var forms (smaller config.min.js)
- refresh_form_config slimmed to clear_cache only (drops generate_config);
  cache invalidated by clear_cache + the form-mutation cache.clear() signal
- add 5 endpoint tests (public, no-cache, shape, parents+children, excludes
  unpublished)

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* [#241] Remove window.forms global; fetch published forms at runtime

- store: allForms (full published list) + forms (assignment-filtered),
  both init [] instead of seeding from window.forms
- util/form.js: fetchPublishedForms() populates allForms; getForms()
  snapshot accessor; reloadData sources from the store
- App.js: fetch on mount, gate render until forms load
- migrate every window.forms / window?.forms consumer to the store/getForms
  (dashboard, filters, submissions, manage-data, manage-draft, approvals,
  header)
- FormBuilderEdit: replace window.location.reload() on publish/unpublish/
  activate-version with fetchPublishedForms() to refresh the store in place
- update tests/snapshots (store, helpers, form, login setup)

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

5651 of 6564 branches covered (86.09%)

Branch coverage included in aggregate %.

10654 of 11891 relevant lines covered (89.6%)

0.9 hits per line