grpc
/
grpc-java
/
#20340
89%
|
Ran
|
Jobs
1
|
Files
661
|
Run time
2min
|
Badge
Embed ▾
README BADGES
|
coverage: 89.033% (-0.02%) from 89.054%
push
github
ejona86Revert "xds: reuse GrpcXdsTransport and underlying gRPC channel to the same xDS server by ref-counting" This reverts commit e39c38bf5. This causes hangs for xds when MAX_CONCURRENT_STREAMS limit is too low for the number of targets being used. Each XdsClient will often use 2 streams (ADS, LRS), so a concurrency limit of 100 will likely have issues after 50 targets. Hitting MAX_CONCURRENT_STREAMS prevents the resource timer from being started as the ADS RPC does not become ready, so users see a hang instead of an xds resource timeout after 15 seconds. b/529399722
37565 of 42192 relevant lines covered (89.03%)
0.89 hits per line
Coverage Regressions
| Lines | Coverage | ∆ | File |
|---|---|---|---|
| 5 |
75.0 |
-3.45% | ../servlet/src/main/java/io/grpc/servlet/ServletServerStream.java |
| 3 |
93.22 |
-1.69% | ../core/src/main/java/io/grpc/internal/AbstractClientStream.java |
| 3 |
95.07 |
-0.44% | ../core/src/main/java/io/grpc/internal/RetriableStream.java |
| 2 |
96.49 |
-0.73% | ../xds/src/main/java/io/grpc/xds/GrpcXdsTransportFactory.java |
| 1 |
87.88 |
-3.03% | ../netty/src/main/java/io/grpc/netty/ClientTransportLifecycleManager.java |
| 1 |
91.02 |
-0.2% | ../netty/src/main/java/io/grpc/netty/NettyServerHandler.java |
| 1 |
92.99 |
0.93% | ../xds/src/main/java/io/grpc/xds/client/ControlPlaneClient.java |
Jobs
| ID | Job ID | Ran | Files | Coverage | |
|---|---|---|---|---|---|
| 1 | #20340.1 | 661 |
89.03 |
