moonbitlang / core / 4904

91%

Build Type

push

github

Committed by bobzhang

Commit Message

feat(immut/hashset): add HashSet constructor, deprecate from_array

The immutable `HashSet` was a positional newtype `struct HashSet(Node?)`,
whose tuple constructor reserved the `HashSet` name, so a `HashSet::HashSet`
function could not be defined.

Give the field a name instead:

    struct HashSet[A] { data : Node[A]? }

This frees the `HashSet` identifier (named structs construct via `{ data: ..}`,
not `HashSet(..)`) while keeping the exact same `Node?` representation, so the
internal logic is unchanged apart from `self.0` -> `self.data` and wrapping
results in `{ data: .. }`. The public type stays abstract (the field is
private), so its `.mbti` is unchanged apart from the new constructor.

Add `HashSet::HashSet(ArrayView[A]) -> HashSet[A]` so a set can be built with
`@hashset.HashSet([...])`, deprecate the old `from_array` (and its `of` alias)
in favour of it, and migrate all usages across the package. The `Show`/`output`
format string and its snapshot tests intentionally keep emitting
`@immut/hashset.from_array([...])`.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Coverage Stats

28 of 28 new or added lines in 1 file covered. (100.0%)

6 existing lines in 3 files now uncovered.

15339 of 16798 relevant lines covered (91.31%)

187712.6 hits per line