Kikobeats / cacheable-response / 28431450579

99%

push

github

fix: skip 304 short-circuit when get bypasses cache (#140)

* fix: skip 304 short-circuit when get bypasses cache

Returning null/undefined from .get() is a documented cache bypass. After
#138 stopped the null crash, matching If-None-Match still triggered a 304
with an empty body because the etag was derived from the {} fallback while
send() was never called.

Only return 304 when memoize produced a stored value (raw is truthy).

Co-authored-by: kikohumanbeatbox <kikohumanbeatbox@gmail.com>

* refactor: gate 304 short-circuit on hasValue instead of raw

The 304 revalidation should fire only when memoize actually had a stored
value. `hasValue` is the semantic flag from @keyvhq/memoize for exactly
that, already destructured at the call site. Gating on `raw` truthiness
worked for the documented bypass case only because compress(undefined)
returns undefined, an implicit coupling; hasValue also stays correct when
.get() returns a falsy primitive.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

---------

Co-authored-by: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: kikohumanbeatbox <kikohumanbeatbox@gmail.com>
Co-authored-by: Kiko Beats <josefrancisco.verdu@gmail.com>
Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>

57 of 60 branches covered (95.0%)

Branch coverage included in aggregate %.

1 of 1 new or added line in 1 file covered. (100.0%)

202 of 202 relevant lines covered (100.0%)

30.97 hits per line