lsm / neokai / 28413226668

82%

Build Type

push

github

Committed by web-flow

Commit Message

fix(space-runtime): don't terminally drop PR events linked to a run (#2210)

* fix(space-runtime): don't terminally drop PR events linked to a run

When handleExternalEvent found no subscription for a PR event, it marked
the event ignored forever. If a subscription appeared later (e.g. a
blocked-run auto-subscription or a deliberate agent subscription), the
event was already lost.

Now, if a GitHub PR event is linked to a workflow run in the space, it
stays published so the redispatch sweep can deliver it once a matching
subscription exists. Events for PRs not linked to any run are still
ignored, and linked events that stay unmatched past EXTERNAL_EVENT_QUEUE_TTL_MS
are marked failed to prevent unbounded growth of space_external_events.

* fix(space-runtime): address review feedback on PR event retention

- Compare parsed PR identities (host/owner/repo/number) instead of raw URLs
  so run URLs with suffixes like /files still match event URLs.
- Keep the PR-linked retention branch inside the no-blocked-hook path only,
  preserving the existing blocked_run_gate_not_opened terminalization.
- Add a periodic TTL sweep in executeTick for published events without
  deliveries, so retained PR-linked events eventually fail even without a
  restart or duplicate webhook.

* fix(space-runtime): nest PR-linked retention under no-hook branch + case-insensitive match

- Move the PR-linked retention check inside the firedRunIds===0 branch so a
  blocked run whose gate-reval hook fires but opens no gate is still
  terminally failed (blocked_run_gate_not_opened), not left published.
- Compare parsed PR identity case-insensitively (host/owner/repo) so a run
  storing a differently-cased owner/repo still matches the canonical event URL.
- Add tests: blocked-run hook fires without opening a gate, and
  case-insensitive owner/repo matching.

Coverage Stats

11448 of 16495 branches covered (69.4%)

Branch coverage included in aggregate %.

86 of 86 new or added lines in 1 file covered. (100.0%)

4 existing lines in 1 file now uncovered.

97697 of 115888 relevant lines covered (84.3%)

296.52 hits per line