Freegle / Iznik / 24053

72%

Build Type

push

circleci

Committed by edwh

Commit Message

fix(modtools): member name search for LoveJunk users + dedupe Blank Reply log

Two moderator-reported ModTools issues:

- Searching approved members by NAME found nothing for LoveJunk members
  (searching by their ID worked). LoveJunk users are created with
  fullname=NULL and their name only in firstname/lastname, but the member
  name-search WHERE clause matched u.fullname only, so NULL LIKE '%term%'
  silently excluded them. Match firstname/lastname too (the displayname is
  already built from them). + Go regression test.
  https://discourse.ilovefreegle.org/t/modtools-changes-likely-bugs/9518/371

- A "Blank Reply" modmail produced a duplicate "Replied" entry in the mod
  log history. The log was written only by the batch processor, whose INSERT
  is unconditional and re-runs whenever the task is retried (e.g. after a
  transient email-spool failure), inserting a second row. handleReply now
  writes the Replied log synchronously and exactly once - consistent with
  the other mod actions (hold/release/repost/edit) - and the batch no longer
  re-writes it for replies. + Go test (log written once) and updated Laravel
  test (batch must not log replies).
  https://discourse.ilovefreegle.org/t/log-history-is-duplicated/9672/6

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

Coverage Stats

568 of 2751 branches covered (20.65%)

Branch coverage included in aggregate %.

21 of 21 new or added lines in 3 files covered. (100.0%)

592 existing lines in 58 files now uncovered.

54569 of 72713 relevant lines covered (75.05%)

41.05 hits per line