ruby-grape / grape / 28403869613

97%

push

github

Fix middleware build crash when a top-level ::Options is in scope (#2773)

Grape::Middleware::Base#initialize used self.class.const_defined?(:Options),
whose default inherit: true reaches top-level constants on Object. When any
loaded gem defines a global ::Options (e.g. the `options` gem, a transitive
dependency of progress_bar), the guard returned true for every middleware
subclass, but `self.class::Options` then raised NameError because the `::`
resolution operator does not fall back to Object. This took down the whole
middleware stack for third-party middleware that does not declare its own
Options (e.g. grape_logging's RequestLogger).

Resolve the constant through self.class::Options directly: `::` already
honours middleware inheritance (e.g. Versioner::Path -> Versioner::Base) and
never falls back to Object, so a global ::Options is no longer matched and an
absent one cleanly yields the legacy DEFAULT_OPTIONS path. Apply the same
treatment to the DEFAULT_OPTIONS lookup, which had the identical defect.

Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

1128 of 1226 branches covered (92.01%)

Branch coverage included in aggregate %.

9 of 9 new or added lines in 1 file covered. (100.0%)

3584 of 3652 relevant lines covered (98.14%)

23085.58 hits per line