ben-manes / caffeine / #5558

100%

master: 100%

push

github

Evaluate the async bulk-load result's values once

AsyncBulkCompleter makes two passes over the loader's returned map:
fillProxies evaluates result.get(key) for each requested key, and
addNewEntries then evaluated entry.getValue() for every entry before
the proxies.containsKey skip -- so a lazy result (e.g. a user's
Maps.transformValues) re-ran the transform on each requested key only
to discard it. The 2016 commit collapsed the sync bulk path to one
pass but left the async completer two-pass.

Move getValue() inside the skip so only the new (unrequested) entries
are evaluated. Add getAll_lazyResult_evaluatesEachValueOnce, which
counts transform invocations on a Maps.transformValues result (under
the bug each requested value is counted twice).

4050 of 4056 branches covered (99.85%)

1 of 1 new or added line in 1 file covered. (100.0%)

8244 of 8245 relevant lines covered (99.99%)

1.0 hits per line