ben-manes / caffeine / #5557

100%

master: 100%

Build Type

push

github

Committed by ben-manes

Commit Message

Align async asMap().computeIfAbsent stats with get

AsyncAsMapView.computeIfAbsent hand-rolled its hit/miss stats and
diverged from AsyncCache.get and the sync asMap().computeIfAbsent:
it deferred a conditional hit and recorded nothing on a throwing or
null-returning mapping function. Mirror get's mechanism
(recordStats=true + handleCompletion(recordMiss=false)) so hit/miss
flow through the same statsAware/afterRead path.

It can't delegate to get directly: get's requireNonNull on the
mapping result and the returned future would break the
Map.computeIfAbsent null-return contract, so this inlines get's body
without those checks.

Stats now match get: present->hit, absent+value->miss+success,
absent+throw->miss+failure, absent+null->miss. The
computeIfAbsent_error/_nullValue/_present_failed assertions pinned
the prior incidental behavior and are corrected to the sync sibling.

Coverage Stats

4045 of 4054 branches covered (99.78%)

2 of 2 new or added lines in 1 file covered. (100.0%)

2 existing lines in 2 files now uncovered.

8243 of 8245 relevant lines covered (99.98%)

1.0 hits per line